Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update foxglove schemas protobuf #3248

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: update foxglove schemas protobuf #3248

wants to merge 4 commits into from
+668 −1

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Nov 25, 2024

  • as tilte

@wep21
Copy link
Contributor Author

wep21 commented Nov 25, 2024

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 25, 2024
@wep21
Copy link
Contributor Author

wep21 commented Nov 25, 2024 •
edited
Loading

@fmeum @meteorcloudy I appreciate it if you could add presubmit auto run tag.

@wep21
Copy link
Contributor Author

wep21 commented Nov 25, 2024

As of rules_cc 0.1.0, cc_proto_library is removed. Is it correct to use cc_proto_library from protobuf instead of rules_cc?

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 25, 2024
@Wyverald
Copy link
Member

As of rules_cc 0.1.0, cc_proto_library is removed. Is it correct to use cc_proto_library from protobuf instead of rules_cc?

yes, protobuf will be the canonical home of cc_proto_library.

@wep21
fix
06ffb0c 
Signed-off-by: wep21 <[email protected]>
@wep21
Copy link
Contributor Author

wep21 commented Nov 25, 2024

ready to merge

Wyverald
Wyverald previously approved these changes Nov 25, 2024
View reviewed changes
@Wyverald Wyverald enabled auto-merge (squash) November 25, 2024 22:12
@wep21 @Wyverald
apply review
5d51c28 
Co-authored-by: Xùdōng Yáng <[email protected]>
auto-merge was automatically disabled November 26, 2024 01:08

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed Wyverald’s stale review November 26, 2024 01:08

Require module maintainers' approval for newly pushed changes.

@wep21 wep21 requested a review from Wyverald November 26, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wep21 @Wyverald @bazel-io